Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 49be13c

Browse filesBrowse files
TrottRafaelGSS
Trott
authored and
RafaelGSS
committed
tools: keep Emeriti lists case-insensitive alphabetic
The current code does not treat capital and lowercase letters as equivalent. PR-URL: #45159 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ad9a5bb commit 49be13c
Copy full SHA for 49be13c

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎tools/find-inactive-collaborators.mjs‎

Copy file name to clipboardExpand all lines: tools/find-inactive-collaborators.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ async function moveCollaboratorToEmeritus(peopleToMove) {
163163
const currentLine = `${collaboratorFirstLine}\n${line}\n`;
164164
// If textToMove is empty, this still works because when undefined is
165165
// used in a comparison with <, the result is always false.
166-
while (textToMove[0] < currentLine) {
166+
while (textToMove[0]?.toLowerCase() < currentLine.toLowerCase()) {
167167
fileContents += textToMove.shift();
168168
}
169169
fileContents += currentLine;
Collapse file

‎tools/find-inactive-tsc.mjs‎

Copy file name to clipboardExpand all lines: tools/find-inactive-tsc.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ async function moveTscToEmeritus(peopleToMove) {
198198
const currentLine = `${memberFirstLine}\n${line}\n`;
199199
// If textToMove is empty, this still works because when undefined is
200200
// used in a comparison with <, the result is always false.
201-
while (textToMove[0] < currentLine) {
201+
while (textToMove[0]?.toLowerCase() < currentLine.toLowerCase()) {
202202
fileContents += textToMove.shift();
203203
}
204204
fileContents += currentLine;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.