Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 48fcd76

Browse filesBrowse files
mcollinatargos
authored andcommitted
tls: implement capture rejections for 'secureConnection' event
PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 5eef00a commit 48fcd76
Copy full SHA for 48fcd76

File tree

Expand file treeCollapse file tree

2 files changed

+48
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+48
-0
lines changed
Open diff view settings
Collapse file

‎lib/_tls_wrap.js‎

Copy file name to clipboardExpand all lines: lib/_tls_wrap.js
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ assertCrypto();
3838
const { setImmediate } = require('timers');
3939
const assert = require('internal/assert');
4040
const crypto = require('crypto');
41+
const EE = require('events');
4142
const net = require('net');
4243
const tls = require('tls');
4344
const common = require('_tls_common');
@@ -1395,6 +1396,19 @@ Server.prototype.addContext = function(servername, context) {
13951396
this._contexts.push([re, tls.createSecureContext(context).context]);
13961397
};
13971398

1399+
Server.prototype[EE.captureRejectionSymbol] = function(
1400+
err, event, sock) {
1401+
1402+
switch (event) {
1403+
case 'secureConnection':
1404+
sock.destroy(err);
1405+
break;
1406+
default:
1407+
net.Server.prototype[Symbol.for('nodejs.rejection')]
1408+
.call(this, err, event, sock);
1409+
}
1410+
};
1411+
13981412
function SNICallback(servername, callback) {
13991413
const contexts = this.server._contexts;
14001414

Collapse file
+34Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
if (!common.hasCrypto)
5+
common.skip('missing crypto');
6+
7+
const assert = require('assert');
8+
const events = require('events');
9+
const fixtures = require('../common/fixtures');
10+
const { createServer, connect } = require('tls');
11+
const cert = fixtures.readKey('rsa_cert.crt');
12+
const key = fixtures.readKey('rsa_private.pem');
13+
14+
events.captureRejections = true;
15+
16+
const server = createServer({ cert, key }, common.mustCall(async (sock) => {
17+
server.close();
18+
19+
const _err = new Error('kaboom');
20+
sock.on('error', common.mustCall((err) => {
21+
assert.strictEqual(err, _err);
22+
}));
23+
throw _err;
24+
}));
25+
26+
server.listen(0, common.mustCall(() => {
27+
const sock = connect({
28+
port: server.address().port,
29+
host: server.address().host,
30+
rejectUnauthorized: false
31+
});
32+
33+
sock.on('close', common.mustCall());
34+
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.