Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 48e3ad3

Browse filesBrowse files
addaleaxjuanarbol
authored andcommitted
build: add option to disable shared readonly heap
PR-URL: #45887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 79e0bf9 commit 48e3ad3
Copy full SHA for 48e3ad3

File tree

Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,12 @@
489489
default=None,
490490
help='[Experimental] Enable V8 pointer compression (limits max heap to 4GB and breaks ABI compatibility)')
491491

492+
parser.add_argument('--disable-shared-readonly-heap',
493+
action='store_true',
494+
dest='disable_shared_ro_heap',
495+
default=None,
496+
help='Disable the shared read-only heap feature in V8')
497+
492498
parser.add_argument('--v8-options',
493499
action='store',
494500
dest='v8_options',
@@ -1524,7 +1530,7 @@ def configure_v8(o):
15241530
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
15251531
o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
15261532
o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
1527-
o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression else 1
1533+
o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
15281534
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
15291535
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
15301536
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ set link_module=
7070
set no_cctest=
7171
set cctest=
7272
set openssl_no_asm=
73+
set no_shared_roheap=
7374
set doc=
7475
set extra_msbuild_args=
7576
set exit_code=0
@@ -149,6 +150,7 @@ if /i "%1"=="link-module" set "link_module= --link-module=%2%link_module%"&got
149150
if /i "%1"=="no-cctest" set no_cctest=1&goto arg-ok
150151
if /i "%1"=="cctest" set cctest=1&goto arg-ok
151152
if /i "%1"=="openssl-no-asm" set openssl_no_asm=1&goto arg-ok
153+
if /i "%1"=="no-shared-roheap" set no_shared_roheap=1&goto arg-ok
152154
if /i "%1"=="doc" set doc=1&goto arg-ok
153155
if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:%config%\node.binlog&goto arg-ok
154156

@@ -206,6 +208,7 @@ if defined config_flags set configure_flags=%configure_flags% %config_flags%
206208
if defined target_arch set configure_flags=%configure_flags% --dest-cpu=%target_arch%
207209
if defined debug_nghttp2 set configure_flags=%configure_flags% --debug-nghttp2
208210
if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm
211+
if defined no_shared_roheap set configure_flags=%configure_flags% --disable-shared-readonly-heap
209212
if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose
210213
if "%target_arch%"=="x86" if "%PROCESSOR_ARCHITECTURE%"=="AMD64" set configure_flags=%configure_flags% --no-cross-compiling
211214

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.