Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 4887214

Browse filesBrowse files
cho-mRafaelGSS
cho-m
authored and
RafaelGSS
committed
build: fix building with system icu 76
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer add `icu-uc` when linking to shared libraries. This results in undefined symbols/references when trying to build with system ICU 76. [^1]: unicode-org/icu@199bc82 PR-URL: #55563 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 6aa797d commit 4887214
Copy full SHA for 4887214

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1879,7 +1879,7 @@ def icu_download(path):
18791879
elif with_intl == 'system-icu':
18801880
# ICU from pkg-config.
18811881
o['variables']['v8_enable_i18n_support'] = 1
1882-
pkgicu = pkg_config('icu-i18n')
1882+
pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
18831883
if not pkgicu[0]:
18841884
error('''Could not load pkg-config data for "icu-i18n".
18851885
See above errors or the README.md.''')

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.