Commit 47fa765
tools: optimize wildcard execution in tools/test.py
Previously for each matching test, it would execute multiple
`node -p` commands to decide the configurations of the executable.
That means if there are 100 tests matched, it will run the Node.js
executable 4*100 times to retrieve the same configurations repeatedly.
This changes the loop order so that it only execute these commands
once and reuse the results for all matching tests.
PR-URL: #60266
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent df8396a commit 47fa765Copy full SHA for 47fa765
File tree
Expand file treeCollapse file tree
1 file changed
+22
-21
lines changedOpen diff view settings
Filter options
- tools
Expand file treeCollapse file tree
1 file changed
+22
-21
lines changedOpen diff view settings
Collapse file
+22-21Lines changed: 22 additions & 21 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1712 | 1712 | |
1713 | 1713 | |
1714 | 1714 | |
1715 | | - |
1716 | | - |
1717 | | - |
1718 | | - |
1719 | | - |
1720 | | - |
1721 | | - |
1722 | | - |
1723 | | - |
1724 | | - |
1725 | | - |
1726 | | - |
1727 | | - |
1728 | | - |
1729 | | - |
1730 | | - |
1731 | | - |
1732 | | - |
1733 | | - |
1734 | | - |
1735 | | - |
| 1715 | + |
| 1716 | + |
| 1717 | + |
| 1718 | + |
| 1719 | + |
| 1720 | + |
| 1721 | + |
| 1722 | + |
| 1723 | + |
| 1724 | + |
| 1725 | + |
| 1726 | + |
| 1727 | + |
| 1728 | + |
| 1729 | + |
| 1730 | + |
| 1731 | + |
| 1732 | + |
| 1733 | + |
| 1734 | + |
| 1735 | + |
| 1736 | + |
1736 | 1737 | |
1737 | 1738 | |
1738 | 1739 | |
|
0 commit comments