Commit 479b622
committed
tls,http2: handle writes after SSL destroy more gracefully
This might otherwise result in a hard crash when trying
to write to a socket after a sudden disconnect.
Note that the test here uses an aborted `h2load` run to create
the failing requests; That’s far from ideal, but it provides
a reasonably reliably reproduction at this point.
PR-URL: #18987
Fixes: #18973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent e584113 commit 479b622Copy full SHA for 479b622
File tree
Expand file treeCollapse file tree
2 files changed
+38
-7
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
2 files changed
+38
-7
lines changedOpen diff view settings
Collapse file
+6-7Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
565 | 565 | |
566 | 566 | |
567 | 567 | |
568 | | - |
| 568 | + |
| 569 | + |
| 570 | + |
| 571 | + |
| 572 | + |
| 573 | + |
569 | 574 | |
570 | 575 | |
571 | 576 | |
| ||
605 | 610 | |
606 | 611 | |
607 | 612 | |
608 | | - |
609 | | - |
610 | | - |
611 | | - |
612 | | - |
613 | | - |
614 | 613 | |
615 | 614 | |
616 | 615 | |
|
Collapse file
test/parallel/test-http2-tls-disconnect.js
Copy file name to clipboard+32Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
0 commit comments