Commit 4737314
test_runner: fix ordering of test hooks
For tests with subtests the before hook was being run after the
beforeEach hook, which is the opposite to test suites and expectations.
Also, a function was being used to close over the after hooks, but at
the point it was being run the after hooks were not yet set up.
Fixes #47915
PR-URL: #47931
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 4bece05 commit 4737314Copy full SHA for 4737314
Expand file treeCollapse file tree
2 files changed
+10
-5
lines changedOpen diff view settings
Collapse file
lib/internal/test_runner/test.js
Copy file name to clipboardExpand all lines: lib/internal/test_runner/test.js+4-4Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
537 | 537 | |
538 | 538 | |
539 | 539 | |
540 | | - |
541 | | - |
542 | | - |
543 | 540 | |
544 | 541 | |
545 | 542 | |
| 543 | + |
| 544 | + |
| 545 | + |
546 | 546 | |
547 | 547 | |
548 | 548 | |
| ||
574 | 574 | |
575 | 575 | |
576 | 576 | |
577 | | - |
578 | 577 | |
| 578 | + |
579 | 579 | |
580 | 580 | |
581 | 581 | |
|
Collapse file
test/fixtures/test-runner/output/hooks.js
Copy file name to clipboardExpand all lines: test/fixtures/test-runner/output/hooks.js+6-1Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
99 | 99 | |
100 | 100 | |
101 | 101 | |
| 102 | + |
| 103 | + |
102 | 104 | |
103 | 105 | |
104 | 106 | |
105 | 107 | |
106 | 108 | |
107 | 109 | |
108 | 110 | |
109 | | - |
| 111 | + |
| 112 | + |
110 | 113 | |
111 | 114 | |
| 115 | + |
112 | 116 | |
113 | 117 | |
114 | 118 | |
| 119 | + |
115 | 120 | |
116 | 121 | |
117 | 122 | |
|
0 commit comments