Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 471a5d8

Browse filesBrowse files
rvaggMylesBorins
rvagg
authored and
MylesBorins
committed
doc: add note re term-size commit on top of npm
Until npm updates update-notifier to a newer version, the dependency tree will contain a version of term-size that has an unsigned macOS binary. This will fail .pkg notarization and will result in failed release builds. We built and signed a term-size and contributed it back to the project for this purpose, but the dependency chain is long enough that it's not likely to be included in a new npm very quickly. Until it is, we need to cherry-pick commit d2f08a1 ontop of any npm updates to master and any other release branch that includes notarization. PR-URL: #32403 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 99f260f commit 471a5d8
Copy full SHA for 471a5d8

File tree

Expand file treeCollapse file tree

1 file changed

+18
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+18
-1
lines changed
Open diff view settings
Collapse file

‎doc/guides/maintaining-npm.md‎

Copy file name to clipboardExpand all lines: doc/guides/maintaining-npm.md
+18-1Lines changed: 18 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,24 @@ Note: please ensure you are only making the updates that are changed by npm.
7474
$ git rebase --whitespace=fix master
7575
```
7676

77-
## Step 7: Test the build
77+
## Step 7: Apply signed term-size commit
78+
79+
The `term-size` package in npm's dependency tree contains an unsigned macOS
80+
binary in versions < 2.2.0. Until npm updates to a newer version of
81+
`update-notifier`, Node.js macOS package files can't be notarized and will fail
82+
to install on macOS Catalina and above.
83+
84+
When `npm ls` shows a `term-size` package version < 2.2.0, cherry-pick
85+
commit `d2f08a1bdb` on top of the upgraded npm.
86+
87+
```console
88+
$ git cherry-pick d2f08a1bdb
89+
```
90+
91+
When `npm ls` shows a `term-size` package version >= 2.2.0, edit this file to
92+
remove this step.
93+
94+
## Step 8: Test the build
7895

7996
```console
8097
$ make test-npm

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.