Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 464df6d

Browse filesBrowse files
LekoMylesBorins
authored andcommitted
src: allow --perf-(basic-)?prof in NODE_OPTIONS
PR-URL: #17600 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 51a8e1d commit 464df6d
Copy full SHA for 464df6d

File tree

Expand file treeCollapse file tree

3 files changed

+13
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+13
-0
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+2Lines changed: 2 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,8 @@ Node options that are allowed are:
475475
V8 options that are allowed are:
476476
- `--abort-on-uncaught-exception`
477477
- `--max-old-space-size`
478+
- `--perf-basic-prof`
479+
- `--perf-prof`
478480
- `--stack-trace-limit`
479481

480482
### `NODE_PENDING_DEPRECATION=1`
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3871,6 +3871,8 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
38713871
"--icu-data-dir",
38723872

38733873
// V8 options (define with '_', which allows '-' or '_')
3874+
"--perf_prof",
3875+
"--perf_basic_prof",
38743876
"--abort_on_uncaught_exception",
38753877
"--max_old_space_size",
38763878
"--stack_trace_limit",
Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,15 @@ expect('--zero-fill-buffers', 'B\n');
2626
expect('--v8-pool-size=10', 'B\n');
2727
expect('--trace-event-categories node', 'B\n');
2828

29+
if (!common.isWindows) {
30+
expect('--perf-basic-prof', 'B\n');
31+
}
32+
33+
if (common.isLinux && ['arm', 'x64', 'mips'].includes(process.arch)) {
34+
// PerfJitLogger is only implemented in Linux.
35+
expect('--perf-prof', 'B\n');
36+
}
37+
2938
if (common.hasCrypto) {
3039
expect('--use-openssl-ca', 'B\n');
3140
expect('--use-bundled-ca', 'B\n');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.