Commit 45fe865
inspector: use js_app.html as the landing page for chrome devtools
As of this commit in chromium -
https://chromium-review.googlesource.com/c/chromium/src/+/905450
a new landing page (js_app.html) has been added and inspector.html
has been made as the fallback page.
Another motivation for this patch is the following bug in
chromium -
https://bugs.chromium.org/p/chromium/issues/detail?id=846642
due to which, source maps won't get applied with inspector.html,
but works with js_app.html
In order to maintain compatibility, this patch adds a URL
"devtoolsFrontendUrlCompat" to the response of /json/list REST API
so that those using Chrome browsers older than 66.0.3345.0
could use this to open DevTools.
PR-URL: #21385
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=846642
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/905450
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>1 parent 51a434f commit 45fe865Copy full SHA for 45fe865
File tree
Expand file treeCollapse file tree
3 files changed
+22
-6
lines changedOpen diff view settings
Filter options
- doc/api
- src
Expand file treeCollapse file tree
3 files changed
+22
-6
lines changedOpen diff view settings
Collapse file
+4-1Lines changed: 4 additions & 1 deletion
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
187 | 187 | |
188 | 188 | |
189 | 189 | |
190 | | - |
| 190 | + |
191 | 191 | |
192 | 192 | |
193 | 193 | |
194 | 194 | |
195 | 195 | |
196 | 196 | |
| 197 | + |
| 198 | + |
| 199 | + |
197 | 200 | |
198 | 201 | |
Collapse file
src/inspector_socket_server.cc
Copy file name to clipboardExpand all lines: src/inspector_socket_server.cc+16-5Lines changed: 16 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
334 | 334 | |
335 | 335 | |
336 | 336 | |
337 | | - |
338 | | - |
339 | | - |
340 | | - |
341 | | - |
| 337 | + |
| 338 | + |
| 339 | + |
| 340 | + |
| 341 | + |
| 342 | + |
342 | 343 | |
343 | 344 | |
344 | 345 | |
345 | 346 | |
346 | 347 | |
| 348 | + |
| 349 | + |
| 350 | + |
| 351 | + |
| 352 | + |
| 353 | + |
| 354 | + |
| 355 | + |
| 356 | + |
| 357 | + |
347 | 358 | |
348 | 359 | |
349 | 360 | |
|
Collapse file
src/inspector_socket_server.h
Copy file name to clipboardExpand all lines: src/inspector_socket_server.h+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
81 | 81 | |
82 | 82 | |
83 | 83 | |
| 84 | + |
| 85 | + |
84 | 86 | |
85 | 87 | |
86 | 88 | |
|
0 commit comments