Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 45fbcbb

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
doc: edit BUILDING.md
I should have done this a few days ago so it could land in time for Code & Learn, but oh well. Here are some revisions to BUILDING.md to try to make it easier to read. PR-URL: #23435 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
1 parent c73a6a0 commit 45fbcbb
Copy full SHA for 45fbcbb

File tree

Expand file treeCollapse file tree

1 file changed

+11
-16
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-16
lines changed
Open diff view settings
Collapse file

‎BUILDING.md‎

Copy file name to clipboardExpand all lines: BUILDING.md
+11-16Lines changed: 11 additions & 16 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ which it is attached.
5252

5353
### Input
5454

55-
Node.js relies on V8 and libuv. Therefore, we adopt a subset of their
56-
supported platforms.
55+
Node.js relies on V8 and libuv. We adopt a subset of their supported platforms.
5756

5857
### Strategy
5958

@@ -111,8 +110,8 @@ platforms in production.
111110
community will only address issues that reproduce on native GNU/Linux
112111
systems. Issues that only reproduce on WSL should be reported in the
113112
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
114-
Windows binary (`node.exe`) in WSL is not recommended, and will not work
115-
without adjustment (such as stdio redirection).
113+
Windows binary (`node.exe`) in WSL is not recommended. It will not work
114+
without workarounds such as stdio redirection.
116115

117116
### Supported toolchains
118117

@@ -144,10 +143,8 @@ Otherwise `configure` will fail with an error. This can be avoided by
144143
either providing a newer assembler as per the list above or by
145144
using the `--openssl-no-asm` flag.
146145

147-
*Note:* The forthcoming OpenSSL-1.1.1 will require higher
148-
version. Please refer
149-
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html for
150-
details.
146+
The forthcoming OpenSSL-1.1.1 will have different requirements. Please refer to
147+
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html for details.
151148

152149
## Building Node.js on supported platforms
153150

@@ -216,7 +213,7 @@ $ make test-only
216213

217214
At this point, you are ready to make code changes and re-run the tests.
218215

219-
If you are running tests prior to submitting a Pull Request, the recommended
216+
If you are running tests before submitting a Pull Request, the recommended
220217
command is:
221218

222219
```console
@@ -344,7 +341,7 @@ Prerequisites:
344341
and tools which can be included in the global `PATH`.
345342
* The [NetWide Assembler](http://www.nasm.us/), for OpenSSL assembler modules.
346343
If not installed in the default location, it needs to be manually added
347-
to `PATH`. Build with `openssl-no-asm` option does not require this.
344+
to `PATH`. A build with the `openssl-no-asm` option does not need this.
348345
* **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/)
349346
and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).
350347

@@ -369,12 +366,10 @@ To test if Node.js was built correctly:
369366

370367
### Android/Android-based devices (e.g. Firefox OS)
371368

372-
Although these instructions for building on Android are provided, please note
373-
that Android is not an officially supported platform at this time. Patches to
374-
improve the Android build are accepted. However, there is no testing on Android
375-
in the current continuous integration environment. The participation of people
376-
dedicated and determined to improve Android building, testing, and support is
377-
encouraged.
369+
Android is not a supported platform. Patches to improve the Android build are
370+
welcome. There is no testing on Android in the current continuous integration
371+
environment. The participation of people dedicated and determined to improve
372+
Android building, testing, and support is encouraged.
378373

379374
Be sure you have downloaded and extracted
380375
[Android NDK](https://developer.android.com/tools/sdk/ndk/index.html) before in

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.