Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 4593539

Browse filesBrowse files
saperFishrock123
saper
authored and
Fishrock123
committed
deps: backport 75e43a6 from v8 upstream
Note: chunk in test-heap.cc:1989 discarded as related code missing from current version in node. Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103} PR-URL: #2636 Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
1 parent 74ff9bc commit 4593539
Copy full SHA for 4593539

File tree

Expand file treeCollapse file tree

3 files changed

+3
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-2
lines changed
Open diff view settings
Collapse file

‎deps/v8/AUTHORS‎

Copy file name to clipboardExpand all lines: deps/v8/AUTHORS
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ Kang-Hao (Kenny) Lu <kennyluck@csail.mit.edu>
6969
Luis Reis <luis.m.reis@gmail.com>
7070
Luke Zarko <lukezarko@gmail.com>
7171
Maciej Małecki <me@mmalecki.com>
72+
Marcin Cieślak <saper@marcincieslak.com>
7273
Mathias Bynens <mathias@qiwi.be>
7374
Matt Hanselman <mjhanselman@gmail.com>
7475
Matthew Sporleder <msporleder@gmail.com>
Collapse file

‎deps/v8/src/runtime/runtime-i18n.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/runtime/runtime-i18n.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ RUNTIME_FUNCTION(Runtime_CreateBreakIterator) {
627627

628628
local_object->SetInternalField(0, reinterpret_cast<Smi*>(break_iterator));
629629
// Make sure that the pointer to adopted text is NULL.
630-
local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));
630+
local_object->SetInternalField(1, static_cast<Smi*>(nullptr));
631631

632632
Factory* factory = isolate->factory();
633633
Handle<String> key = factory->NewStringFromStaticChars("breakIterator");
Collapse file

‎deps/v8/test/cctest/test-heap.cc‎

Copy file name to clipboardExpand all lines: deps/v8/test/cctest/test-heap.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ TEST(HandleNull) {
126126
Isolate* isolate = CcTest::i_isolate();
127127
HandleScope outer_scope(isolate);
128128
LocalContext context;
129-
Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
129+
Handle<Object> n(static_cast<Object*>(nullptr), isolate);
130130
CHECK(!n.is_null());
131131
}
132132

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.