Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 45322df

Browse filesBrowse files
Trotttargos
Trott
authored and
targos
committed
test: skip some pummel tests on slower machines
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent 4b073b0 commit 45322df
Copy full SHA for 45322df

File tree

Expand file treeCollapse file tree

6 files changed

+41
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+41
-5
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-crypto-dh-hash-modp18.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-crypto-dh-hash-modp18.js
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,15 @@
2121

2222
'use strict';
2323
const common = require('../common');
24-
if (!common.hasCrypto)
24+
25+
if (!common.hasCrypto) {
2526
common.skip('node compiled without OpenSSL.');
27+
}
28+
29+
if ((process.config.variables.arm_version === '6') ||
30+
(process.config.variables.arm_version === '7')) {
31+
common.skip('Too slow for armv6 and armv7 bots');
32+
}
2633

2734
const assert = require('assert');
2835
const crypto = require('crypto');
Collapse file

‎test/pummel/test-crypto-dh-hash.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-crypto-dh-hash.js
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,15 @@
2121

2222
'use strict';
2323
const common = require('../common');
24-
if (!common.hasCrypto)
24+
25+
if (!common.hasCrypto) {
2526
common.skip('node compiled without OpenSSL.');
27+
}
28+
29+
if ((process.config.variables.arm_version === '6') ||
30+
(process.config.variables.arm_version === '7')) {
31+
common.skip('Too slow for armv6 and armv7 bots');
32+
}
2633

2734
const assert = require('assert');
2835
const crypto = require('crypto');
Collapse file

‎test/pummel/test-crypto-dh-keys.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-crypto-dh-keys.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
'use strict';
2323
const common = require('../common');
24+
2425
if (!common.hasCrypto) {
2526
common.skip('node compiled without OpenSSL.');
2627
}
Collapse file

‎test/pummel/test-dh-regr.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-dh-regr.js
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,15 @@
2121

2222
'use strict';
2323
const common = require('../common');
24-
if (!common.hasCrypto)
24+
25+
if (!common.hasCrypto) {
2526
common.skip('missing crypto');
27+
}
28+
29+
if ((process.config.variables.arm_version === '6') ||
30+
(process.config.variables.arm_version === '7')) {
31+
common.skip('Too slow for armv6 and armv7 bots');
32+
}
2633

2734
const assert = require('assert');
2835
const crypto = require('crypto');
Collapse file

‎test/pummel/test-next-tick-infinite-calls.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-next-tick-infinite-calls.js
+6-1Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
require('../common');
23+
const common = require('../common');
24+
25+
if ((process.config.variables.arm_version === '6') ||
26+
(process.config.variables.arm_version === '7')) {
27+
common.skip('Too slow for armv6 and armv7 bots');
28+
}
2429

2530
let complete = 0;
2631

Collapse file

‎test/pummel/test-policy-integrity.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-policy-integrity.js
+10-1Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
'use strict';
22

33
const common = require('../common');
4-
if (!common.hasCrypto) common.skip('missing crypto');
4+
5+
if (!common.hasCrypto) {
6+
common.skip('missing crypto');
7+
}
8+
9+
if ((process.config.variables.arm_version === '6') ||
10+
(process.config.variables.arm_version === '7')) {
11+
common.skip('Too slow for armv6 and armv7 bots');
12+
}
13+
514
common.requireNoPackageJSONAbove();
615

716
const { debuglog } = require('util');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.