Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 4480b14

Browse filesBrowse files
targosevanlucas
targos
authored and
evanlucas
committed
build: use BUILDTYPE when building V8 in Makefile
Without this it would always compile Release and Debug builds. Ref: #7477 PR-URL: #7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 94a486a commit 4480b14
Copy full SHA for 4480b14

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ cctest: all
112112

113113
v8:
114114
tools/make-v8.sh v8
115-
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
115+
$(MAKE) -C deps/v8 $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)
116116

117117
test: all
118118
$(MAKE) build-addons

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.