Commit 4471369
committed
http2: send error text in case of ALPN mismatch
Send a human-readable HTTP/1 response in case of an unexpected
ALPN protocol. This helps with debugging this condition,
since previously the only result of it would be a closed socket.
PR-URL: #18986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 12856b0 commit 4471369Copy full SHA for 4471369
File tree
Expand file treeCollapse file tree
2 files changed
+21
-5
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+21
-5
lines changedOpen diff view settings
Collapse file
+11-2Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2488 | 2488 | |
2489 | 2489 | |
2490 | 2490 | |
2491 | | - |
2492 | | - |
| 2491 | + |
| 2492 | + |
| 2493 | + |
| 2494 | + |
| 2495 | + |
| 2496 | + |
| 2497 | + |
| 2498 | + |
| 2499 | + |
| 2500 | + |
| 2501 | + |
2493 | 2502 | |
2494 | 2503 | |
2495 | 2504 | |
|
Collapse file
test/parallel/test-http2-https-fallback.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-https-fallback.js+10-3Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
9 | | - |
| 9 | + |
10 | 10 | |
11 | 11 | |
12 | 12 | |
| ||
131 | 131 | |
132 | 132 | |
133 | 133 | |
134 | | - |
| 134 | + |
| 135 | + |
135 | 136 | |
136 | 137 | |
| 138 | + |
137 | 139 | |
138 | | - |
| 140 | + |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
| 145 | + |
139 | 146 | |
140 | 147 | |
0 commit comments