Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 43f2aba

Browse filesBrowse files
addaleaxruyadorno
authored andcommitted
src: slightly simplify V8CoverageConnection::GetFilename
PR-URL: #41748 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
1 parent 869cbb7 commit 43f2aba
Copy full SHA for 43f2aba

File tree

Expand file treeCollapse file tree

1 file changed

+6
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-12
lines changed
Open diff view settings
Collapse file

‎src/inspector_profiler.cc‎

Copy file name to clipboardExpand all lines: src/inspector_profiler.cc
+6-12Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -170,18 +170,12 @@ static bool EnsureDirectory(const std::string& directory, const char* type) {
170170
}
171171

172172
std::string V8CoverageConnection::GetFilename() const {
173-
std::string thread_id = std::to_string(env()->thread_id());
174-
std::string pid = std::to_string(uv_os_getpid());
175-
std::string timestamp = std::to_string(
176-
static_cast<uint64_t>(GetCurrentTimeInMicroseconds() / 1000));
177-
char filename[1024];
178-
snprintf(filename,
179-
sizeof(filename),
180-
"coverage-%s-%s-%s.json",
181-
pid.c_str(),
182-
timestamp.c_str(),
183-
thread_id.c_str());
184-
return filename;
173+
uint64_t timestamp =
174+
static_cast<uint64_t>(GetCurrentTimeInMicroseconds() / 1000);
175+
return SPrintF("coverage-%s-%s-%s.json",
176+
uv_os_getpid(),
177+
timestamp,
178+
env()->thread_id());
185179
}
186180

187181
void V8ProfilerConnection::WriteProfile(Local<Object> result) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.