Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 43e8357

Browse filesBrowse files
bnoordhuisFishrock123
authored andcommitted
src: fix readability/namespace cpplint warnings
PR-URL: #7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent 5fd1585 commit 43e8357
Copy full SHA for 43e8357

File tree

Expand file treeCollapse file tree

6 files changed

+11
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+11
-8
lines changed
Open diff view settings
Collapse file

‎src/node_win32_etw_provider.cc‎

Copy file name to clipboardExpand all lines: src/node_win32_etw_provider.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,4 +187,5 @@ void shutdown_etw() {
187187
advapi = nullptr;
188188
}
189189
}
190-
}
190+
191+
} // namespace node
Collapse file

‎src/spawn_sync.h‎

Copy file name to clipboardExpand all lines: src/spawn_sync.h
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,8 @@ class SyncProcessRunner {
222222

223223
Environment* env_;
224224
};
225-
}
225+
226+
} // namespace node
226227

227228
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
228229

Collapse file

‎src/string_search.cc‎

Copy file name to clipboardExpand all lines: src/string_search.cc
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ namespace stringsearch {
66
int StringSearchBase::kBadCharShiftTable[kUC16AlphabetSize];
77
int StringSearchBase::kGoodSuffixShiftTable[kBMMaxShift + 1];
88
int StringSearchBase::kSuffixTable[kBMMaxShift + 1];
9-
}
10-
} // namespace node::stringsearch
9+
10+
} // namespace stringsearch
11+
} // namespace node
Collapse file

‎src/string_search.h‎

Copy file name to clipboardExpand all lines: src/string_search.h
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -623,8 +623,8 @@ size_t SearchString(Vector<const Char> subject,
623623
StringSearch<Char> search(pattern);
624624
return search.Search(subject, start_index);
625625
}
626-
}
627-
} // namespace node::stringsearch
626+
} // namespace stringsearch
627+
} // namespace node
628628

629629
namespace node {
630630
using node::stringsearch::Vector;
Collapse file

‎test/addons/make-callback-recurse/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/make-callback-recurse/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ void Initialize(Local<Object> target) {
2626
NODE_SET_METHOD(target, "makeCallback", MakeCallback);
2727
}
2828

29-
} // namespace anonymous
29+
} // namespace
3030

3131
NODE_MODULE(binding, Initialize)
Collapse file

‎test/addons/make-callback/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/make-callback/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ void Initialize(v8::Local<v8::Object> target) {
3535
NODE_SET_METHOD(target, "makeCallback", MakeCallback);
3636
}
3737

38-
} // namespace anonymous
38+
} // namespace
3939

4040
NODE_MODULE(binding, Initialize)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.