Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 438d9de

Browse filesBrowse files
lpincatargos
authored andcommitted
events: make eventTarget.removeAllListeners() return this
Fixes: #35762 PR-URL: #35805 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 8074f69 commit 438d9de
Copy full SHA for 438d9de

File tree

Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Collapse file

‎doc/api/events.md‎

Copy file name to clipboardExpand all lines: doc/api/events.md
+2Lines changed: 2 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1525,6 +1525,8 @@ added: v14.5.0
15251525

15261526
* `type` {string}
15271527

1528+
* Returns: {EventTarget} this
1529+
15281530
Node.js-specific extension to the `EventTarget` class. If `type` is specified,
15291531
removes all registered listeners for `type`, otherwise removes all registered
15301532
listeners.
Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,8 @@ class NodeEventTarget extends EventTarget {
476476
} else {
477477
this[kEvents].clear();
478478
}
479+
480+
return this;
479481
}
480482
}
481483

Collapse file

‎test/parallel/test-nodeeventtarget.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-nodeeventtarget.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,11 @@ const { on } = require('events');
117117
strictEqual(eventTarget.listenerCount('foo'), 2);
118118
strictEqual(eventTarget.listenerCount('bar'), 1);
119119
deepStrictEqual(eventTarget.eventNames(), ['foo', 'bar']);
120-
eventTarget.removeAllListeners('foo');
120+
strictEqual(eventTarget.removeAllListeners('foo'), eventTarget);
121121
strictEqual(eventTarget.listenerCount('foo'), 0);
122122
strictEqual(eventTarget.listenerCount('bar'), 1);
123123
deepStrictEqual(eventTarget.eventNames(), ['bar']);
124-
eventTarget.removeAllListeners();
124+
strictEqual(eventTarget.removeAllListeners(), eventTarget);
125125
strictEqual(eventTarget.listenerCount('foo'), 0);
126126
strictEqual(eventTarget.listenerCount('bar'), 0);
127127
deepStrictEqual(eventTarget.eventNames(), []);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.