Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 433fb9a

Browse filesBrowse files
indutnyMyles Borins
authored andcommitted
deps: cherry-pick 1383d00 from v8 upstream
Original commit message: tools: fix tickprocessor Cpp symbols on mac Despite man page documentation: -f Display the symbol table of a dynamic library flat (as one file not separate modules). `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument does not seem to be required, so just remove it completely. (For `-format` documentation - see `nm --help` on mac). BUG= Review URL: https://codereview.chromium.org/1840633002 Cr-Commit-Position: refs/heads/master@{#35445} Fix: #5903 PR-URL: #6179 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
1 parent 4ec9ae8 commit 433fb9a
Copy full SHA for 433fb9a

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎deps/v8/tools/tickprocessor.js‎

Copy file name to clipboardExpand all lines: deps/v8/tools/tickprocessor.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -750,8 +750,11 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider);
750750
MacCppEntriesProvider.prototype.loadSymbols = function(libName) {
751751
this.parsePos = 0;
752752
libName = this.targetRootFS + libName;
753+
754+
// It seems that in OS X `nm` thinks that `-f` is a format option, not a
755+
// "flat" display option flag.
753756
try {
754-
this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), ''];
757+
this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), ''];
755758
} catch (e) {
756759
// If the library cannot be found on this system let's not panic.
757760
this.symbols = '';

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.