Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 42cd952

Browse filesBrowse files
targostargos
committed
deps: silence irrelevant V8 warning
PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #49639 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 88cf90f commit 42cd952
Copy full SHA for 42cd952

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.1',
39+
'v8_embedder_string': '-node.2',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/include/v8-persistent-handle.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8-persistent-handle.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class NonCopyablePersistentTraits {
241241
* This will clone the contents of storage cell, but not any of the flags, etc.
242242
*/
243243
template <class T>
244-
struct V8_DEPRECATED("Use v8::Global instead") CopyablePersistentTraits {
244+
struct CopyablePersistentTraits {
245245
using CopyablePersistent = Persistent<T, CopyablePersistentTraits<T>>;
246246
static const bool kResetInDestructor = true;
247247
template <class S, class M>

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.