Commit 429113e
http2: move events to the JSStreamSocket
When using a JSStreamSocket, the
HTTP2Session constructor will replace
the socket object
http2 events should be attached to the
JSStreamSocket object because the http2
session handle lives there
Fixes: #35695
PR-URL: #35772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>1 parent 06cc400 commit 429113eCopy full SHA for 429113e
File tree
Expand file treeCollapse file tree
2 files changed
+61
-3
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+61
-3
lines changedOpen diff view settings
Collapse file
+6-3Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3132 | 3132 | |
3133 | 3133 | |
3134 | 3134 | |
3135 | | - |
3136 | | - |
3137 | | - |
3138 | 3135 | |
3139 | 3136 | |
| 3137 | + |
| 3138 | + |
| 3139 | + |
| 3140 | + |
| 3141 | + |
| 3142 | + |
3140 | 3143 | |
3141 | 3144 | |
3142 | 3145 | |
|
Collapse file
test/parallel/test-http2-client-jsstream-destroy.js
Copy file name to clipboard+55Lines changed: 55 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
0 commit comments