Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 420d56c

Browse filesBrowse files
bnoordhuisMylesBorins
authored andcommitted
src: don't touch js object in Http2Session dtor
Don't try to update the internal field pointer of the JS object in the destructor. The garbage collector invokes the destructor when the object is collected and is not necessarily in a valid state anymore. Backport-PR-URL: #19185 PR-URL: #18656 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent f89f659 commit 420d56c
Copy full SHA for 420d56c

File tree

Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,6 @@ Http2Session::Http2Session(Environment* env,
531531

532532
Http2Session::~Http2Session() {
533533
CHECK_EQ(flags_ & SESSION_STATE_HAS_SCOPE, 0);
534-
if (!object().IsEmpty())
535-
ClearWrap(object());
536534
DEBUG_HTTP2SESSION(this, "freeing nghttp2 session");
537535
nghttp2_session_del(session_);
538536
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.