Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 40c8e6d

Browse filesBrowse files
evanlucasMyles Borins
evanlucas
authored and
Myles Borins
committed
net: remove hot path comment from connect
This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: #4648 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 9ca24de commit 40c8e6d
Copy full SHA for 40c8e6d

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎lib/net.js‎

Copy file name to clipboardExpand all lines: lib/net.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,6 @@ function lookupAndConnect(self, options) {
931931
port |= 0;
932932

933933
// If host is an IP, skip performing a lookup
934-
// TODO(evanlucas) should we hot path this for localhost?
935934
var addressType = exports.isIP(host);
936935
if (addressType) {
937936
process.nextTick(function() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.