Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3f6f968

Browse filesBrowse files
sam-githubtargos
authored andcommitted
test: skip tests related to CI failures on AIX
These tests seem to trigger failures in the entire CI job (not just the test) on AIX. Skip them to see if that helps alleviate spurious failures in node-test-commit-aix (and the upstream PR and commit test jobs). See: - nodejs/build#1820 (comment) - nodejs/build#1847 (comment) PR-URL: #28469 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 1b4a7fb commit 3f6f968
Copy full SHA for 3f6f968

File tree

Expand file treeCollapse file tree

4 files changed

+15
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+15
-0
lines changed
Open diff view settings
Collapse file

‎test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js‎

Copy file name to clipboardExpand all lines: test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
55
if (!common.enoughTestMem)
66
common.skip(skipMessage);
77

8+
// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
9+
// See https://github.com/nodejs/node/pull/28469
10+
if (process.platform === 'aix')
11+
common.skip('flaky on AIX');
12+
813
const binding = require(`./build/${common.buildType}/binding`);
914

1015
// v8 fails silently if string length > v8::String::kMaxLength
Collapse file

‎test/message/message.status‎

Copy file name to clipboardExpand all lines: test/message/message.status
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,6 @@ prefix message
1616

1717
[$system==freebsd]
1818

19+
[$system==aix]
20+
# https://github.com/nodejs/node/pull/28469
21+
vm_dont_display_syntax_error: SKIP
Collapse file

‎test/pseudo-tty/pseudo-tty.status‎

Copy file name to clipboardExpand all lines: test/pseudo-tty/pseudo-tty.status
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
prefix pseudo-tty
22

33
[$system==aix]
4+
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
5+
# https://github.com/nodejs/node/pull/28469
6+
console-dumb-tty: SKIP
7+
test-fatal-error: SKIP
48

59
[$system==solaris]
610
# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
Collapse file

‎test/sequential/sequential.status‎

Copy file name to clipboardExpand all lines: test/sequential/sequential.status
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,8 @@ test-http2-large-file: PASS, FLAKY
1919
[$system==freebsd]
2020

2121
[$system==aix]
22+
# https://github.com/nodejs/node/pull/28469
23+
test-async-wrap-getasyncid: SKIP
24+
test-buffer-creation-regression: SKIP
2225

2326
[$arch==arm]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.