Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3f02855

Browse filesBrowse files
guybedfordtargos
authored andcommitted
module: move cjs type check behind flag
PR-URL: #29732 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
1 parent b5c24df commit 3f02855
Copy full SHA for 3f02855

File tree

Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/modules/cjs/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ Module.prototype._compile = function(content, filename) {
952952

953953
// Native extension for .js
954954
Module._extensions['.js'] = function(module, filename) {
955-
if (filename.endsWith('.js')) {
955+
if (experimentalModules && filename.endsWith('.js')) {
956956
const pkg = readPackageScope(filename);
957957
if (pkg && pkg.type === 'module') {
958958
throw new ERR_REQUIRE_ESM(filename);
Collapse file

‎test/es-module/test-esm-type-flag-errors.js‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-type-flag-errors.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Flags: --experimental-modules
12
'use strict';
23
const common = require('../common');
34
const assert = require('assert');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.