Commit 3edb04d
src: remove 2nd
In the document for fs, there are several functions that state "No
arguments other than a possible exception are given to the completion
callback." (ex> fs.access, fs.chmod, fs.close, ..)
But, the functions are invoking the callback with two parameters (err,
undefined)
It causes problems in using several API like
[async.waterfall](https://caolan.github.io/async/docs.html#waterfall).
PR-URL: #20629
Fixes: #20335
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>undefined argument in node_file.cc1 parent 83119db commit 3edb04dCopy full SHA for 3edb04d
File tree
Expand file treeCollapse file tree
3 files changed
+24
-4
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
3 files changed
+24
-4
lines changedOpen diff view settings
Collapse file
+3-1Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
421 | 421 | |
422 | 422 | |
423 | 423 | |
424 | | - |
| 424 | + |
| 425 | + |
| 426 | + |
425 | 427 | |
426 | 428 | |
427 | 429 | |
|
Collapse file
test/parallel/test-fs-access.js
Copy file name to clipboardExpand all lines: test/parallel/test-fs-access.js+9-3Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
64 | 64 | |
65 | 65 | |
66 | 66 | |
67 | | - |
| 67 | + |
| 68 | + |
| 69 | + |
68 | 70 | |
69 | 71 | |
70 | 72 | |
71 | | - |
| 73 | + |
| 74 | + |
| 75 | + |
72 | 76 | |
73 | 77 | |
74 | 78 | |
75 | | - |
| 79 | + |
| 80 | + |
| 81 | + |
76 | 82 | |
77 | 83 | |
78 | 84 | |
|
Collapse file
test/parallel/test-fs-close.js
Copy file name to clipboard+12Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
0 commit comments