Commit 3e14212
test: remove magic numbers in test-gc-http-client-onerror
Remove magic numbers (500, 10, 100) from the test. Instead, detect when
GC has started and stop sending requests at that point.
On my laptop, this results in 16 or 20 requests per run instead of 500.
Fixes: #23089
PR-URL: #24943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 4a858b2 commit 3e14212Copy full SHA for 3e14212
File tree
Expand file treeCollapse file tree
1 file changed
+30
-23
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+30
-23
lines changedOpen diff view settings
Collapse file
test/parallel/test-gc-http-client-onerror.js
Copy file name to clipboardExpand all lines: test/parallel/test-gc-http-client-onerror.js+30-23Lines changed: 30 additions & 23 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
| 9 | + |
| 10 | + |
9 | 11 | |
10 | 12 | |
11 | 13 | |
12 | 14 | |
13 | 15 | |
14 | 16 | |
15 | 17 | |
16 | | - |
| 18 | + |
17 | 19 | |
18 | 20 | |
19 | 21 | |
20 | 22 | |
21 | | - |
22 | | - |
23 | 23 | |
24 | 24 | |
25 | | - |
26 | | - |
| 25 | + |
| 26 | + |
27 | 27 | |
28 | 28 | |
29 | | - |
30 | | - |
31 | | - |
32 | | - |
33 | | - |
34 | | - |
35 | | - |
36 | | - |
37 | | - |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
38 | 36 | |
39 | | - |
40 | | - |
| 37 | + |
| 38 | + |
41 | 39 | |
42 | | - |
| 40 | + |
| 41 | + |
43 | 42 | |
44 | 43 | |
45 | 44 | |
46 | 45 | |
47 | | - |
| 46 | + |
48 | 47 | |
49 | 48 | |
50 | 49 | |
| ||
55 | 54 | |
56 | 55 | |
57 | 56 | |
58 | | - |
| 57 | + |
59 | 58 | |
60 | 59 | |
61 | | - |
62 | | - |
63 | | - |
64 | | - |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
| 70 | + |
| 71 | + |
65 | 72 | |
0 commit comments