Commit 3dddc01
doc,test: fix concurrency option of test()
The documentation appears to still be wrong w.r.t. the meaning of the
concurrency option of the test() function. The implementation appears to
default to Infinity when the option is set to true. Is that intended or
a good idea? I don't know. It certainly makes more sense than what the
documentation says (which is basing the number of concurrent tasks
within a single thread on the number of CPU cores).
This changes the documentation to hopefully match the implementation and
adds a test that rules out the (rather arbitrary) behavior described in
the documentation.
Refs: #47365
Refs: #47642
PR-URL: #47734
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 4c0036b commit 3dddc01Copy full SHA for 3dddc01
File tree
Expand file treeCollapse file tree
2 files changed
+19
-3
lines changedOpen diff view settings
Filter options
- doc/api
- test/parallel
Expand file treeCollapse file tree
2 files changed
+19
-3
lines changedOpen diff view settings
Collapse file
+2-3Lines changed: 2 additions & 3 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
785 | 785 | |
786 | 786 | |
787 | 787 | |
788 | | - |
789 | | - |
790 | | - |
| 788 | + |
| 789 | + |
791 | 790 | |
792 | 791 | |
793 | 792 | |
|
Collapse file
test/parallel/test-runner-concurrency.js
Copy file name to clipboardExpand all lines: test/parallel/test-runner-concurrency.js+17Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7 | 7 | |
8 | 8 | |
9 | 9 | |
| 10 | + |
10 | 11 | |
11 | 12 | |
12 | 13 | |
| ||
35 | 36 | |
36 | 37 | |
37 | 38 | |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
38 | 55 | |
39 | 56 | |
40 | 57 | |
|
0 commit comments