Commit 3dcdab3
events: check signal before listener
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.
PR-URL: #46054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>1 parent 8684dae commit 3dcdab3Copy full SHA for 3dcdab3
File tree
Expand file treeCollapse file tree
2 files changed
+2
-9
lines changedOpen diff view settings
Filter options
- lib/internal
- test/wpt/status/dom
Expand file treeCollapse file tree
2 files changed
+2
-9
lines changedOpen diff view settings
Collapse file
lib/internal/event_target.js
Copy file name to clipboardExpand all lines: lib/internal/event_target.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
561 | 561 | |
562 | 562 | |
563 | 563 | |
| 564 | + |
| 565 | + |
564 | 566 | |
565 | 567 | |
566 | 568 | |
| ||
575 | 577 | |
576 | 578 | |
577 | 579 | |
578 | | - |
579 | | - |
580 | 580 | |
581 | 581 | |
582 | 582 | |
|
Collapse file
test/wpt/status/dom/events.json
Copy file name to clipboardExpand all lines: test/wpt/status/dom/events.json-7Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
8 | 8 | |
9 | 9 | |
10 | 10 | |
11 | | - |
12 | | - |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | | - |
18 | 11 | |
19 | 12 | |
20 | 13 | |
|
0 commit comments