Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3db13a8

Browse filesBrowse files
Trottaddaleax
authored andcommitted
doc: remove breaking-change-helper from onboarding-extras
I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: #34497 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
1 parent 9f46500 commit 3db13a8
Copy full SHA for 3db13a8

File tree

Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed
Open diff view settings
Collapse file

‎doc/guides/onboarding-extras.md‎

Copy file name to clipboardExpand all lines: doc/guides/onboarding-extras.md
-8Lines changed: 0 additions & 8 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ such as if CI run fails or a new outstanding review comment is posted.
4646
section to the docs"
4747
* major vs. everything else: run last versions tests against this version, if
4848
they pass, **probably** minor or patch
49-
* A breaking change helper
50-
([full source](https://gist.github.com/chrisdickinson/ba532fa0e4e243fb7b44)):
51-
52-
```bash
53-
SHOW=$(git show-ref -d $(git describe --abbrev=0) | tail -n1 | awk '{print $1}')
54-
git checkout $(git show -s --pretty='%T' $SHOW) -- test
55-
make -j4 test
56-
```
5749

5850
### LTS/Version labels
5951

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.