Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3bebcf0

Browse filesBrowse files
BridgeARaddaleax
authored andcommitted
test: fix failing assertion
One test did not cause an assertion. By changing the test to use `assert.throws()` all tests have to throw, otherwise the test will fail. PR-URL: #25250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e09dd0c commit 3bebcf0
Copy full SHA for 3bebcf0

File tree

Expand file treeCollapse file tree

1 file changed

+9
-11
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+9
-11
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-assert.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert.js
+9-11Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -257,16 +257,14 @@ const circular = { y: 1 };
257257
circular.x = circular;
258258

259259
function testAssertionMessage(actual, expected, msg) {
260-
try {
261-
assert.strictEqual(actual, '');
262-
} catch (e) {
263-
assert.strictEqual(
264-
e.message,
265-
msg || strictEqualMessageStart +
266-
`+ actual - expected\n\n+ ${expected}\n- ''`
267-
);
268-
assert.ok(e.generatedMessage, 'Message not marked as generated');
269-
}
260+
assert.throws(
261+
() => assert.strictEqual(actual, ''),
262+
{
263+
generatedMessage: true,
264+
message: msg || strictEqualMessageStart +
265+
`+ actual - expected\n\n+ ${expected}\n- ''`
266+
}
267+
);
270268
}
271269

272270
function testShortAssertionMessage(actual, expected) {
@@ -280,7 +278,7 @@ testShortAssertionMessage(false, 'false');
280278
testShortAssertionMessage(100, '100');
281279
testShortAssertionMessage(NaN, 'NaN');
282280
testShortAssertionMessage(Infinity, 'Infinity');
283-
testShortAssertionMessage('', '""');
281+
testShortAssertionMessage('a', '"a"');
284282
testShortAssertionMessage('foo', '\'foo\'');
285283
testShortAssertionMessage(0, '0');
286284
testShortAssertionMessage(Symbol(), 'Symbol()');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.