Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3b6cf09

Browse filesBrowse files
TrottBethGriggs
authored andcommitted
doc: use GFM footnotes in maintaining-V8.md (#40476)
PR-URL: #40476 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent dea7010 commit 3b6cf09
Copy full SHA for 3b6cf09

File tree

Expand file treeCollapse file tree

1 file changed

+8
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-12
lines changed
Open diff view settings
Collapse file

‎doc/guides/maintaining-V8.md‎

Copy file name to clipboardExpand all lines: doc/guides/maintaining-V8.md
+8-12Lines changed: 8 additions & 12 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ documented [on the V8 wiki][V8MergingPatching]. The summary of the process is:
5252

5353
At any given time Node.js needs to be maintaining a few different V8 branches
5454
for the various Current, LTS, and nightly releases. At present this list
55-
includes the following branches<sup>1</sup>:
55+
includes the following branches:[^1]
5656

5757
<table>
5858
<tr>
@@ -222,7 +222,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change.
222222
* Run the Node.js [V8 CI][] in addition to the [Node.js CI][].
223223
The CI uses the `test-v8` target in the `Makefile`, which uses
224224
`tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to
225-
run V8 tests<sup>2</sup>.
225+
run V8 tests.[^2]
226226

227227
The [`git-node`][] tool can be used to simplify this task. Run
228228
`git node v8 backport <sha>` to cherry-pick a commit.
@@ -404,17 +404,13 @@ This would require some tooling to:
404404
promoted from `nodejs/v8` to `nodejs/node`.
405405
* Enabled the V8-CI build in Jenkins to build from the `nodejs/v8` fork.
406406

407-
<!-- Footnotes themselves at the bottom. -->
407+
[^1]: Node.js 0.12 and older are intentionally omitted from this document
408+
as their support has ended.
408409

409-
### Notes
410-
411-
<sup>1</sup>Node.js 0.12 and older are intentionally omitted from this document
412-
as their support has ended.
413-
414-
<sup>2</sup>The V8 tests still require Python 2. To run these tests locally,
415-
you can run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
416-
of this repository. On macOS, this also requires a full Xcode install,
417-
not just the "command line tools" for Xcode.
410+
[^2]: The V8 tests still require Python 2. To run these tests locally, you can
411+
run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
412+
of this repository. On macOS, this also requires a full Xcode install,
413+
not just the "command line tools" for Xcode.
418414

419415
[ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar
420416
[Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.