Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3b252a6

Browse filesBrowse files
chasestarrMylesBorins
authored andcommitted
doc: clarify macosx-firewall suggestion BUILDING
`./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. PR-URL: #10311 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 122917d commit 3b252a6
Copy full SHA for 3b252a6

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎BUILDING.md‎

Copy file name to clipboardExpand all lines: BUILDING.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ On OS X, you will also need:
2424
this under the menu `Xcode -> Preferences -> Downloads`
2525
* This step will install `gcc` and the related toolchain containing `make`
2626

27-
* You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid
28-
popups asking to accept incoming network connections when running tests:
27+
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
28+
to avoid popups asking to accept incoming network connections when running tests:
2929

3030
```console
3131
$ sudo ./tools/macosx-firewall.sh

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.