Commit 3a80104
doc: remove section about amending commits in PR guide
In my first contribution, I got the amending guidance wrongly and
amended my commit to attend some requested changes.
Amending commits is never required to author a PR in the project, and
force pushing makes reviewing harder, so the PR guide should not
recommend it as a good practice.
PR-URL: #41287
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 58da5d9 commit 3a80104Copy full SHA for 3a80104
File tree
Expand file treeCollapse file tree
1 file changed
+4
-11
lines changedOpen diff view settings
Filter options
- doc/guides/contributing
Expand file treeCollapse file tree
1 file changed
+4
-11
lines changedOpen diff view settings
Collapse file
doc/guides/contributing/pull-requests.md
Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md+4-11Lines changed: 4 additions & 11 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
306 | 306 | |
307 | 307 | |
308 | 308 | |
309 | | - |
310 | | - |
311 | | - |
312 | | - |
313 | | - |
314 | | - |
315 | | - |
316 | | - |
317 | | - |
318 | | - |
319 | | - |
| 309 | + |
| 310 | + |
| 311 | + |
| 312 | + |
320 | 313 | |
321 | 314 | |
322 | 315 | |
|
0 commit comments