Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3a54bb5

Browse filesBrowse files
bnoordhuisgibfahn
authored andcommitted
src: remove superfluous HandleScope
Accessors implicitly run inside a HandleScope, UDPWrap::GetFD() doesn't need to create one explicitly. PR-URL: #16482 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 77c02aa commit 3a54bb5
Copy full SHA for 3a54bb5

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎src/udp_wrap.cc‎

Copy file name to clipboardExpand all lines: src/udp_wrap.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ void UDPWrap::New(const FunctionCallbackInfo<Value>& args) {
169169
void UDPWrap::GetFD(Local<String>, const PropertyCallbackInfo<Value>& args) {
170170
int fd = UV_EBADF;
171171
#if !defined(_WIN32)
172-
HandleScope scope(args.GetIsolate());
173172
UDPWrap* wrap = Unwrap<UDPWrap>(args.Holder());
174173
if (wrap != nullptr)
175174
uv_fileno(reinterpret_cast<uv_handle_t*>(&wrap->handle_), &fd);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.