nodejs
diff --git a/Collapse file
‎lib/_http_agent.js‎
Copy file name to clipboardExpand all lines: lib/_http_agent.js
-2Lines changed: 0 additions & 2 deletions b/Collapse file
‎lib/_http_agent.js‎
Copy file name to clipboardExpand all lines: lib/_http_agent.js
-2Lines changed: 0 additions & 2 deletions
diff --git a/Collapse file
‎test/parallel/test-http-agent-maxsockets-regress-4050.js‎
Copy file name to clipboard
+43Lines changed: 43 additions & 0 deletions b/Collapse file
‎test/parallel/test-http-agent-maxsockets-regress-4050.js‎
Copy file name to clipboard
+43Lines changed: 43 additions & 0 deletions
@@ -66,7 +66,6 @@ function Agent(options) {
           count += self.sockets[name].length;
 
         if (count > self.maxSockets || freeLen >= self.maxFreeSockets) {
-          self.removeSocket(socket, options);
           socket.destroy();
         } else {
           freeSockets = freeSockets || [];
@@ -78,7 +77,6 @@ function Agent(options) {
           freeSockets.push(socket);
         }
       } else {
-        self.removeSocket(socket, options);
         socket.destroy();
       }
     }
 
@@ -0,0 +1,43 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+
+const MAX_SOCKETS = 2;
+
+const agent = new http.Agent({
+  keepAlive: true,
+  keepAliveMsecs: 1000,
+  maxSockets: MAX_SOCKETS,
+  maxFreeSockets: 2
+});
+
+const server = http.createServer(function(req, res) {
+  res.end('hello world');
+});
+
+function get(path, callback) {
+  return http.get({
+    host: 'localhost',
+    port: common.PORT,
+    agent: agent,
+    path: path
+  }, callback);
+}
+
+server.listen(common.PORT, function() {
+  var finished = 0;
+  const num_requests = 6;
+  for (var i = 0; i < num_requests; i++) {
+    const request = get('/1', function() {
+    });
+    request.on('response', function() {
+      request.abort();
+      const sockets = agent.sockets[Object.keys(agent.sockets)[0]];
+      assert(sockets.length <= MAX_SOCKETS);
+      if (++finished === num_requests) {
+        server.close();
+      }
+    });
+  }
+});
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ function Agent(options) {`
`66`	`66`	`count += self.sockets[name].length;`
`67`	`67`
`68`	`68`	`if (count > self.maxSockets \|\| freeLen >= self.maxFreeSockets) {`
`69`		`- self.removeSocket(socket, options);`
`70`	`69`	`socket.destroy();`
`71`	`70`	`} else {`
`72`	`71`	`freeSockets = freeSockets \|\| [];`
`@@ -78,7 +77,6 @@ function Agent(options) {`
`78`	`77`	`freeSockets.push(socket);`
`79`	`78`	`}`
`80`	`79`	`} else {`
`81`		`- self.removeSocket(socket, options);`
`82`	`80`	`socket.destroy();`
`83`	`81`	`}`
`84`	`82`	`}`