Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 38fd790

Browse filesBrowse files
committed
tty: fix console printing on Windows
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent f607577 commit 38fd790
Copy full SHA for 38fd790

File tree

Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed
Open diff view settings
Collapse file

‎lib/tty.js‎

Copy file name to clipboardExpand all lines: lib/tty.js
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
const util = require('util');
2525
const net = require('net');
2626
const { TTY, isTTY } = process.binding('tty_wrap');
27-
const { makeSyncWrite } = require('internal/net');
2827
const { inherits } = util;
2928
const errnoException = util._errnoException;
3029
const errors = require('internal/errors');
@@ -80,8 +79,6 @@ function WriteStream(fd) {
8079
// even though it was originally intended to change in v1.0.2 (Libuv 1.2.1).
8180
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
8281
this._handle.setBlocking(true);
83-
this._writev = null;
84-
this._write = makeSyncWrite(fd);
8582

8683
var winSize = new Array(2);
8784
var err = this._handle.getWindowSize(winSize);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.