Commit 387e292
authored
src: generate default snapshot with --predictable
To improve determinism of snapshot generation, add --predictable
to the V8 flags used to initialize a process launched to generate
snapshot. Also add a kGeneratePredictableSnapshot flag
to ProcessInitializationFlags for this and moves the configuration
of these flags into node::InitializeOncePerProcess() so that
it can be shared by embedders.
PR-URL: #48749
Refs: nodejs/build#3043
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 81e4d2e commit 387e292Copy full SHA for 387e292
File tree
Expand file treeCollapse file tree
3 files changed
+10
-3
lines changedOpen diff view settings
Filter options
- src
- tools/snapshot
Expand file treeCollapse file tree
3 files changed
+10
-3
lines changedOpen diff view settings
Collapse file
+6Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
838 | 838 | |
839 | 839 | |
840 | 840 | |
| 841 | + |
| 842 | + |
| 843 | + |
| 844 | + |
| 845 | + |
| 846 | + |
841 | 847 | |
842 | 848 | |
843 | 849 | |
|
Collapse file
+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
265 | 265 | |
266 | 266 | |
267 | 267 | |
| 268 | + |
| 269 | + |
268 | 270 | |
269 | 271 | |
270 | 272 | |
|
Collapse file
tools/snapshot/node_mksnapshot.cc
Copy file name to clipboardExpand all lines: tools/snapshot/node_mksnapshot.cc+2-3Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
50 | 50 | |
51 | 51 | |
52 | 52 | |
53 | | - |
54 | | - |
55 | 53 | |
56 | 54 | |
57 | 55 | |
| ||
65 | 63 | |
66 | 64 | |
67 | 65 | |
68 | | - |
| 66 | + |
| 67 | + |
69 | 68 | |
70 | 69 | |
71 | 70 | |
|
0 commit comments