Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 37c9828

Browse filesBrowse files
committed
deps: disable trap handler for Windows cross-compiler
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent dfb97fb commit 37c9828
Copy full SHA for 37c9828

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.7',
39+
'v8_embedder_string': '-node.8',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/src/trap-handler/trap-handler.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/trap-handler/trap-handler.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace trap_handler {
2727
#define V8_TRAP_HANDLER_SUPPORTED true
2828
// Arm64 simulator on x64 on Linux, Mac, or Windows.
2929
#elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_X64 && \
30-
(V8_OS_LINUX || V8_OS_MACOSX || V8_OS_WIN)
30+
(V8_OS_LINUX || V8_OS_MACOSX)
3131
#define V8_TRAP_HANDLER_VIA_SIMULATOR
3232
#define V8_TRAP_HANDLER_SUPPORTED true
3333
// Everything else is unsupported.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.