Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 373ffc5

Browse filesBrowse files
bnoordhuisMyles Borins
authored andcommitted
installer: don't install node_internals.h
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
1 parent 65b75b5 commit 373ffc5
Copy full SHA for 373ffc5

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎tools/install.py‎

Copy file name to clipboardExpand all lines: tools/install.py
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ def headers(action):
150150
'config.gypi',
151151
'src/node.h',
152152
'src/node_buffer.h',
153-
'src/node_internals.h',
154153
'src/node_object_wrap.h',
155154
'src/node_version.h',
156155
], 'include/node/')

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.