Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 366c983

Browse filesBrowse files
richardlauBridgeAR
richardlau
authored and
BridgeAR
committed
build: fix cctest target for --without-report
Conditionally build `test/cctest/test_report_util.cc` only when configured to include the diagnostic report feature. PR-URL: #28238 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 225fb1b commit 366c983
Copy full SHA for 366c983

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,6 @@
10961096
'test/cctest/test_linked_binding.cc',
10971097
'test/cctest/test_per_process.cc',
10981098
'test/cctest/test_platform.cc',
1099-
'test/cctest/test_report_util.cc',
11001099
'test/cctest/test_traced_value.cc',
11011100
'test/cctest/test_util.cc',
11021101
'test/cctest/test_url.cc',
@@ -1134,6 +1133,9 @@
11341133
},
11351134
}],
11361135
[ 'node_report=="true"', {
1136+
'sources': [
1137+
'test/cctest/test_report_util.cc',
1138+
],
11371139
'defines': [
11381140
'NODE_REPORT',
11391141
'NODE_ARCH="<(target_arch)"',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.