Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 359fff1

Browse filesBrowse files
legendecasruyadorno
authored andcommitted
src,build: add no user defined deduction guides of CTAD check
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 17b6931 commit 359fff1
Copy full SHA for 359fff1

File tree

Expand file treeCollapse file tree

3 files changed

+7
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-2
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,7 @@
481481
'-Wno-unused-parameter',
482482
'-Werror=undefined-inline',
483483
'-Werror=extra-semi',
484+
'-Werror=ctad-maybe-unsupported',
484485
],
485486
},
486487

Collapse file

‎node.gypi‎

Copy file name to clipboardExpand all lines: node.gypi
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@
2727

2828
'conditions': [
2929
[ 'clang==1', {
30-
'cflags': [ '-Werror=undefined-inline', '-Werror=extra-semi']
30+
'cflags': [
31+
'-Werror=undefined-inline',
32+
'-Werror=extra-semi',
33+
'-Werror=ctad-maybe-unsupported',
34+
],
3135
}],
3236
[ '"<(_type)"=="executable"', {
3337
'msvs_settings': {
Collapse file

‎src/quic/session.cc‎

Copy file name to clipboardExpand all lines: src/quic/session.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1531,7 +1531,7 @@ void Session::EmitDatagram(Store&& datagram, DatagramReceivedFlags flag) {
15311531
DCHECK(!is_destroyed());
15321532
if (!env()->can_call_into_js()) return;
15331533

1534-
CallbackScope cbv_scope(this);
1534+
CallbackScope<Session> cbv_scope(this);
15351535

15361536
Local<Value> argv[] = {datagram.ToUint8Array(env()),
15371537
v8::Boolean::New(env()->isolate(), flag.early)};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.