Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 351ebf2

Browse filesBrowse files
benjamingrruyadorno
authored andcommitted
test: improve stability of oom test
The OOM test uses a value that caused an OOM crash from V8 on certain machines when V8 did not notify the host of OOM soon enough. PR-URL: #41681 Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 311050e commit 351ebf2
Copy full SHA for 351ebf2

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-windows-failed-heap-allocation.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-windows-failed-heap-allocation.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const tmpdir = require('../common/tmpdir');
1919
tmpdir.refresh();
2020

2121
// --max-old-space-size=3 is the min 'old space' in V8, explodes fast
22-
const cmd = `"${process.execPath}" --max-old-space-size=3 "${__filename}"`;
23-
exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err) => {
22+
const cmd = `"${process.execPath}" --max-old-space-size=30 "${__filename}"`;
23+
exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err, stdout, stderr) => {
2424
const msg = `Wrong exit code of ${err.code}! Expected 134 for abort`;
2525
// Note: common.nodeProcessAborted() is not asserted here because it
2626
// returns true on 134 as well as 0x80000003 (V8's base::OS::Abort)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.