Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 34de901

Browse filesBrowse files
evanlucasrvagg
evanlucas
authored and
rvagg
committed
build: only define NODE_V8_OPTIONS if not empty
Previously, V8::SetFlagsFromString was called on every launch even if NODE_V8_OPTIONS was an empty string. This patch only defines NODE_V8_OPTIONS if node_v8_options is not an empty string. PR-URL: #2532 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent 0db0e53 commit 34de901
Copy full SHA for 34de901

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@
179179
'defines': [
180180
'NODE_ARCH="<(target_arch)"',
181181
'NODE_PLATFORM="<(OS)"',
182-
'NODE_V8_OPTIONS="<(node_v8_options)"',
183182
'NODE_WANT_INTERNALS=1',
184183
],
185184

@@ -188,6 +187,9 @@
188187
[ 'node_tag!=""', {
189188
'defines': [ 'NODE_TAG="<(node_tag)"' ],
190189
}],
190+
[ 'node_v8_options!=""', {
191+
'defines': [ 'NODE_V8_OPTIONS="<(node_v8_options)"'],
192+
}],
191193
# No node_main.cc for anything except executable
192194
[ 'node_target_type!="executable"', {
193195
'sources!': [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.