Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 34d9e48

Browse filesBrowse files
santigimenoMyles Borins
authored andcommitted
test: fix http-upgrade-client flakiness
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 556703d commit 34d9e48
Copy full SHA for 34d9e48

File tree

Expand file treeCollapse file tree

1 file changed

+8
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-upgrade-client.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-upgrade-client.js
+8-3Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,14 @@ srv.listen(common.PORT, '127.0.0.1', function() {
3434

3535
var req = http.get({ port: common.PORT });
3636
req.on('upgrade', function(res, socket, upgradeHead) {
37-
// XXX: This test isn't fantastic, as it assumes that the entire response
38-
// from the server will arrive in a single data callback
39-
assert.equal(upgradeHead, 'nurtzo');
37+
var recvData = upgradeHead;
38+
socket.on('data', function(d) {
39+
recvData += d;
40+
});
41+
42+
socket.on('close', common.mustCall(function() {
43+
assert.equal(recvData, 'nurtzo');
44+
}));
4045

4146
console.log(res.headers);
4247
var expectedHeaders = {'hello': 'world',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.