Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3491f73

Browse filesBrowse files
watildeaduh95
authored andcommitted
lib: fix FLOAT_32 and FLOAT_64 type constants in ffi
PR-URL: #62892 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bryan English <bryan@bryanenglish.com>
1 parent c9d5bae commit 3491f73
Copy full SHA for 3491f73

1 file changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/ffi/types.cc‎

Copy file name to clipboardExpand all lines: src/ffi/types.cc
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,11 @@ v8::Maybe<ffi_type*> ToFFIType(Environment* env, std::string_view type_str) {
246246
return Just(&ffi_type_sint64);
247247
} else if (type_str == "u64" || type_str == "uint64") {
248248
return Just(&ffi_type_uint64);
249-
} else if (type_str == "f32" || type_str == "float") {
249+
} else if (type_str == "f32" || type_str == "float" ||
250+
type_str == "float32") {
250251
return Just(&ffi_type_float);
251-
} else if (type_str == "f64" || type_str == "double") {
252+
} else if (type_str == "f64" || type_str == "double" ||
253+
type_str == "float64") {
252254
return Just(&ffi_type_double);
253255
} else if (type_str == "buffer" || type_str == "arraybuffer" ||
254256
type_str == "string" || type_str == "str" ||

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.