Commit 34821f6
repl: don't terminate on null thrown
Previous behavior was to assume an error is a proper error in the
repl module. A check was added to not terminate the process on thrown
repl errors that are `null` or `undefined`.
PR-URL: #14306
Fixes: #12373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com1 parent 53ad91c commit 34821f6Copy full SHA for 34821f6
File tree
Expand file treeCollapse file tree
2 files changed
+32
-2
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+32
-2
lines changedOpen diff view settings
Collapse file
+8-2Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
282 | 282 | |
283 | 283 | |
284 | 284 | |
| 285 | + |
285 | 286 | |
| 287 | + |
286 | 288 | |
287 | 289 | |
288 | 290 | |
289 | 291 | |
290 | 292 | |
291 | | - |
| 293 | + |
292 | 294 | |
293 | 295 | |
294 | 296 | |
295 | | - |
| 297 | + |
| 298 | + |
| 299 | + |
| 300 | + |
| 301 | + |
296 | 302 | |
297 | 303 | |
298 | 304 | |
|
Collapse file
test/parallel/test-repl-null-thrown.js
Copy file name to clipboard+24Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
0 commit comments