Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3401315

Browse filesBrowse files
tniessentargos
authored andcommitted
test: use newish OpenSSL feature in test-tls-dhe
According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key. Refs: nodejs/node-v0.x-archive#8272 PR-URL: #46708 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 320ddc0 commit 3401315
Copy full SHA for 3401315

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-tls-dhe.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-dhe.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ function test(keylen, expectedCipher, cb) {
7777
out += d;
7878
});
7979
client.stdout.on('end', function() {
80-
// DHE key length can be checked -brief option in s_client but it
81-
// is only supported in openssl 1.0.2 so we cannot check it.
80+
assert(keylen === 'error' ||
81+
out.includes(`Server Temp Key: DH, ${keylen} bits`));
8282
const reg = new RegExp(`Cipher : ${expectedCipher}`);
8383
if (reg.test(out)) {
8484
nsuccess++;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.