Commit 33d04fd
inspector: no async tracking for promises
`Promise` instances are already tracked by V8 itself.
This fixes `sequential/test-inspector-async-stack-traces-promise-then`
in debug mode (it previously crashed because our tracking
and the V8 tracking were not properly nested).
PR-URL: #17118
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/707058
Fixes: #17017
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c5cd4f0 commit 33d04fdCopy full SHA for 33d04fd
File tree
Expand file treeCollapse file tree
2 files changed
+13
-2
lines changedOpen diff view settings
Filter options
- lib/internal
- test/sequential
Expand file treeCollapse file tree
2 files changed
+13
-2
lines changedOpen diff view settings
Collapse file
lib/internal/inspector_async_hook.js
Copy file name to clipboardExpand all lines: lib/internal/inspector_async_hook.js+12-1Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
16 | 16 | |
17 | 17 | |
18 | 18 | |
19 | | - |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
20 | 23 | |
21 | 24 | |
22 | 25 | |
| 26 | + |
| 27 | + |
23 | 28 | |
24 | 29 | |
25 | 30 | |
26 | 31 | |
| 32 | + |
| 33 | + |
27 | 34 | |
28 | 35 | |
29 | 36 | |
30 | 37 | |
| 38 | + |
| 39 | + |
31 | 40 | |
32 | 41 | |
33 | 42 | |
34 | 43 | |
| 44 | + |
| 45 | + |
35 | 46 | |
36 | 47 | |
37 | 48 | |
|
Collapse file
test/sequential/test-inspector-async-stack-traces-promise-then.js
Copy file name to clipboardExpand all lines: test/sequential/test-inspector-async-stack-traces-promise-then.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
54 | 54 | |
55 | 55 | |
56 | 56 | |
57 | | - |
| 57 | + |
58 | 58 | |
59 | 59 | |
60 | 60 | |
|
0 commit comments