Commit 33af09f
test,net: add tests for server.connections
There were no tests confirming situations where server.connections
should return `null`. Add a test for that situation.
Expand existing server.connection test slightly to check value.
Refactor (mostly spacing) code for server.connections setter.
PR-URL: #10762
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent d751afa commit 33af09fCopy full SHA for 33af09f
File tree
Expand file treeCollapse file tree
3 files changed
+56
-7
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
3 files changed
+56
-7
lines changedOpen diff view settings
Collapse file
+2-3Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1132 | 1132 | |
1133 | 1133 | |
1134 | 1134 | |
1135 | | - |
1136 | | - |
1137 | | - |
| 1135 | + |
| 1136 | + |
1138 | 1137 | |
1139 | 1138 | |
1140 | 1139 | |
|
Collapse file
test/parallel/test-net-server-connections-child-null.js
Copy file name to clipboard+44Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
Collapse file
test/parallel/test-net-server-connections.js
Copy file name to clipboard+10-4Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | | - |
| 2 | + |
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | 6 | |
7 | | - |
8 | | - |
9 | | - |
10 | 7 | |
11 | 8 | |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
12 | 16 | |
| 17 | + |
| 18 | + |
0 commit comments